ci: amend link checker to always be true#1074
Open
WillFortMadeTech wants to merge 1 commit intomadetech:mainfrom
Open
ci: amend link checker to always be true#1074WillFortMadeTech wants to merge 1 commit intomadetech:mainfrom
WillFortMadeTech wants to merge 1 commit intomadetech:mainfrom
Conversation
Contributor
|
What I've found is that we actually do want and need external URL checking to ensure that our docs are up to date. See this PR for more info: #1085 For that, I think this PR is a bit of a no-go, sadly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change amends the link tracker to a non-falsy value which should allow the pipeline to work on merges from forks of this repository, increasing accessibility and supporting this repo's ambition as an open-source employee handbook.
it is likely (although I can't see workflow runs, failures, secrets etc) that this secret is already set. Forks don't have this secret.
This essentially removes the need for this secret, so its use will need to be assessed before approving this PR.