Skip to content

Drop A or AAAA requests more safely#85

Closed
Cuthead wants to merge 2 commits intomacronut:mainfrom
Cuthead:aaaa
Closed

Drop A or AAAA requests more safely#85
Cuthead wants to merge 2 commits intomacronut:mainfrom
Cuthead:aaaa

Conversation

@Cuthead
Copy link

@Cuthead Cuthead commented Feb 8, 2026

Currently, if hint contains ipv6 and does not contain fakeip, all request type including A, NS or HTTPS would be rewritten to AAAA and the response appended to records.IPv6Hint.

1st request:

gfw.report.        0    IN    HTTPS    1 . ipv6hint=2606:4700:3036::ac43:8456,2606:4700:3037::6815:cbd

2nd request:

gfw.report.        0    IN    HTTPS    1 . ipv6hint=2606:4700:3036::ac43:8456,2606:4700:3037::6815:cbd,2606:4700:3037::6815:cbd,2606:4700:3036::ac43:8456

3rd request:

gfw.report.        0    IN    HTTPS    1 . ipv6hint=2606:4700:3036::ac43:8456,2606:4700:3037::6815:cbd,2606:4700:3037::6815:cbd,2606:4700:3036::ac43:8456,2606:4700:3036::ac43:8456,2606:4700:3037::6815:cbd

It should, instead of rewriting all request types, only drop A or AAAA request, like it does for ServerOptions.

@Cuthead Cuthead marked this pull request as draft February 8, 2026 15:59
@Cuthead Cuthead marked this pull request as ready for review February 8, 2026 19:44
@macronut macronut closed this Feb 11, 2026
@Cuthead
Copy link
Author

Cuthead commented Feb 11, 2026

b167997 just removes this rewrite in NSRequest, making hint ipv6 without hint fakeip ineffective.

@Cuthead Cuthead deleted the aaaa branch February 11, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants