Skip to content

Automated fix for refs/heads/RegionalAccessBoundaryFetcher #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: RegionalAccessBoundaryFetcher
Choose a base branch
from
Open

Automated fix for refs/heads/RegionalAccessBoundaryFetcher #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions test/core/credentials/call/regional_access_boundary_fetcher_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,8 @@ int httpcli_get_network_error(const grpc_http_request* /*request*/,
const URI& /*uri*/, Timestamp /*deadline*/,
grpc_closure* on_done,
grpc_http_response* /*response*/) {
ExecCtx::Run(DEBUG_LOCATION, on_done, absl::UnavailableError("Connection refused"));
ExecCtx::Run(DEBUG_LOCATION, on_done,
absl::UnavailableError("Connection refused"));
return 1;
}

Expand Down Expand Up @@ -426,9 +427,12 @@ TEST_F(RegionalAccessBoundaryFetcherTest, NetworkErrorLogsResponseCorrectly) {

bool found_log = false;
for (const auto& msg : log_sink.messages) {
if (absl::StrContains(msg, "Regional access boundary request will be retried")) {
if (absl::StrContains(msg,
"Regional access boundary request will be retried")) {
found_log = true;
EXPECT_THAT(msg, ::testing::HasSubstr("failing with error: UNAVAILABLE:Connection refused"));
EXPECT_THAT(msg,
::testing::HasSubstr(
"failing with error: UNAVAILABLE:Connection refused"));
EXPECT_THAT(msg, ::testing::HasSubstr("HTTP Status: 0"));
EXPECT_THAT(msg, ::testing::Not(::testing::HasSubstr("Body:")));
}
Expand Down Expand Up @@ -862,14 +866,10 @@ TEST(IsValidEmailTest, CustomEmailsValidation) {
bool expected_valid;
};
std::vector<TestCase> test_cases = {
{"foo@bar.com", true},
{"foo@bar", false},
{"foo@bar@baz.com", false},
{"@bar.com", false},
{"foo@bar.com.", true},
{"foo@.bar.com", true},
{"foo@bar..com", true},
{"foo@bar.", false},
{"foo@bar.com", true}, {"foo@bar", false},
{"foo@bar@baz.com", false}, {"@bar.com", false},
{"foo@bar.com.", true}, {"foo@.bar.com", true},
{"foo@bar..com", true}, {"foo@bar.", false},
};
for (const auto& tc : test_cases) {
EXPECT_EQ(EmailFetcher::IsValidEmail(tc.email), tc.expected_valid)
Expand Down