Skip to content

Automated fix for refs/heads/RegionalAccessBoundaryFetcher #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: RegionalAccessBoundaryFetcher
Choose a base branch
from
Open

Automated fix for refs/heads/RegionalAccessBoundaryFetcher #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/credentials/call/regional_access_boundary_fetcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ void EmailFetcher::Fetch(absl::string_view token,
MutexLock lock(&mu_);
auto* rab_fetcher =
std::get_if<RefCountedPtr<RegionalAccessBoundaryFetcher>>(&state_);
if (rab_fetcher == nullptr) return; // Don't yet have RAB fetcher.
if (rab_fetcher == nullptr) return; // Don't yet have RAB fetcher.
if (*rab_fetcher == nullptr) return; // Shouldn't happen, but be defensive.
(*rab_fetcher)->Fetch(token, initial_metadata);
}
Expand Down
5 changes: 2 additions & 3 deletions test/core/credentials/call/regional_access_boundary_fetcher_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,9 +718,8 @@ TEST_F(EmailFetcherTest, EarlyDestructionDoesNotCrash) {
}
}

int httpcli_get_spiffe_id(const grpc_http_request* /*request*/,
const URI& uri, Timestamp /*deadline*/,
grpc_closure* on_done,
int httpcli_get_spiffe_id(const grpc_http_request* /*request*/, const URI& uri,
Timestamp /*deadline*/, grpc_closure* on_done,
grpc_http_response* response) {
if (uri.path() ==
"/computeMetadata/v1/instance/service-accounts/default/email") {
Expand Down