Bug fix fixes bww imported single timings that should be second timings#25
Open
AndyMac4321 wants to merge 3 commits into
Conversation
…ings Added new method in controller that Fixes BWW imported single timings that should be second timings Added .vscode folder to .gitignore
Removed extraneous imports
Removed commented imports
Owner
|
Thank you, this is a useful feature. I'd prefer to do it in the ImportBWW parser itself - adding a lastToken field to the Parser, and then in timelineStart() it can check if the last token was a TIME_LINE_END and if so it can remove the last timing (if it was a single timing) and create the second timing. The advantage of that is that it means we don't have to leak the StartNote/EndNote from the Timings, and also it's a bit faster (although that's not a huge problem for BWW importing). If you'd like to do this, that'd be great, otherwise I'm happy to (I realise you've probably moved on to other things!). Also, I'm sorry it's taken so long to review these pull requests! Thank you very much for putting in the effort, I appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new method in controller that Fixes BWW imported single timings that should be second timings
Added .vscode folder to .gitignore