Skip to content

prefer early return #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ltvragr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prefer early return #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions lib/rubocop/git/style_guide.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,23 +57,17 @@ def config
end

def rubocop_options
if config["ShowCopNames"]
{ debug: true }
else
{}
end.merge(@rubocop_options)
return @rubocop_options unless config["ShowCopNames"]
{ debug: true }.merge(@rubocop_options)
end

def override_config
if @override_config_content
config_content = YAML.load(@override_config_content)
override_config = RuboCop::Config.new(config_content, "")
override_config.add_missing_namespaces
override_config.make_excludes_absolute
override_config
else
{}
end
return {} unless @override_config_content
config_content = YAML.load(@override_config_content)
override_config = RuboCop::Config.new(config_content, "")
override_config.add_missing_namespaces
override_config.make_excludes_absolute
override_config
end

# TODO: DELETE ME when we drop support for 0.x releases of rubocop
Expand Down