Remove unneeded unit expression #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes downstream clippy warnings on #[derive(IOwrite)]:
warning: unneeded unit expression
--> src/types.rs:195:59
|
195 | #[derive(Debug, Copy, Clone, DerivePread, Pwrite, IOread, IOwrite, SizeWith)]
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)
Contributor
Author
|
@m4b does this look reasonable to you? |
Contributor
Author
|
Would it be possible to cut a release with this? |
Owner
|
Yea we can do a minor release |
Owner
|
@tamird released in 0.12.1 |
Contributor
Author
|
@m4b doesn't look like it? https://crates.io/crates/scroll/versions |
Owner
|
scroll_derive contains your change, as well as some others, which was released as 0.12.1 |
anakryiko
pushed a commit
to anakryiko/btfdump
that referenced
this pull request
Apr 7, 2025
scroll_derive 0.12.1 contains m4b/scroll#112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes downstream clippy warnings on #[derive(IOwrite)]:
warning: unneeded unit expression
--> src/types.rs:195:59
|
195 | #[derive(Debug, Copy, Clone, DerivePread, Pwrite, IOread, IOwrite, SizeWith)]
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: this warning originates in the derive macro
IOwrite(in Nightly builds, run with -Z macro-backtrace for more info)