When systemd service fail to start, use an exponential backoff delay to restart it #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to restart it This solves an issue that on (at least) Fedora and if NetworkManager starts too slow, systemd may stop trying to start it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue that on (at least) Fedora and if NetworkManager starts too slow, systemd may stop trying to start it after hitting
StartLimitBurstlimit.Thanks to systemd 254, by providing
RestartStepsandRestartMaxDelaySecoptions, we can let the service retry at an exponential backoff delay.I choose the exponential factor to be 1.618, maxed at 76 seconds, because Fibonacci backoff seems to be another popular backoff sequence. By my educated guess, I think this should be a good number to start with?
I am not sure if this change would ruin somewhere else. Please cast your opinions before I merge it to the master branch.