ndt7: start improving ping implementation #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff has been written by @darkk as part of #234 and has been extracted #234 by @bassosimone, with the objective of merging these low hanging fruits while we look into the proper way of implementing the `/ping` endpoint. Closes #242
Collaborator
Pull Request Test Coverage Report for Build 1203
💛 - Coveralls |
Collaborator
Author
|
Oh, noes, conflicts! I am going to solve them now! |
Conflicted in: ndt7/download/download.go ndt7/measurer/measurer.go ndt7/upload/upload.go While there `wholectx` => `ctx` based on @gfr10598 feedback when we were looking at this code together.
Collaborator
Author
|
@pboothe I have fixed conflicts, can you perhaps maybe take another look? |
Contributor
|
FYI, I'd very much like to see a ping beacon client, that would ping many nearby servers, and a random set of far away servers, every 5 minutes or so. But we need a server that would collect the data, too. |
Contributor
|
@bassosimone would you be willing to rebase this PR and re-submit for review? Is it still relevant? |
Collaborator
Author
|
I am willing, but I would not expect this to happen ~immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff has been written by @darkk as part of #234 and
has been extracted #234 by @bassosimone, with the objective
of merging these low hanging fruits while we look into the
proper way of implementing the
/pingendpoint.Closes #242
This change is