fix module scoping

[lyninx]

No description provided.

[Copilot]

Pull Request Overview

This PR fixes a scoping issue where module functions with the same name as local identifiers were incorrectly shadowed by those local variables. The fix ensures that when calling module functions, the function scope (containing module function definitions) takes precedence over the outer scope (containing local variables).

Key changes:

• Reversed the order of Map.merge arguments in func_access evaluation to prioritize function scope over outer scope
• Added test coverage for the specific case of module functions sharing names with local identifiers
• Uncommented a previously skipped test for nested module functions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
lib/lunary.ex	Fixed scope merging order in func_access evaluation to prioritize function scope
test/unit/module_test.exs	Added test case for module functions with same name as local identifiers
test/unit/chain_test.exs	Uncommented previously skipped test for nested module functions

Comments suppressed due to low confidence (1)

lib/lunary.ex:400

• The merge order is inconsistent with the fix at line 133. This should be Map.merge(scope, func_scope) to ensure function scope takes priority, matching the behavior in the func_access evaluation clause. The current order would cause the same shadowing bug in chained module function calls.

        merged_scope = Map.merge(func_scope, scope) # is this overly broad?

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.