fdfitter: Improve inversion performance (Friday afternoon)#558
Draft
JoepVanlier wants to merge 3 commits into
Draft
fdfitter: Improve inversion performance (Friday afternoon)#558JoepVanlier wants to merge 3 commits into
JoepVanlier wants to merge 3 commits into
Conversation
3eace10 to
c131335
Compare
c131335 to
1d774a7
Compare
6ec258a to
d1854f6
Compare
d1854f6 to
5513b15
Compare
5513b15 to
d7b1282
Compare
216eb25 to
09224bc
Compare
09224bc to
0134bbc
Compare
71515fe to
45211ea
Compare
45211ea to
91f67fe
Compare
91f67fe to
c98433e
Compare
7feb2dc to
ef1b6f0
Compare
we didn't include the entire independent range, resulting in an interpolant that covered less of the range than desired
has a fallback chute for when bracketing fails
ef1b6f0 to
2490d21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model inversion can be pretty slow and generally, it is cumbersome to have to specify the inversion bounds.
This draft fixes both these issues by introducing a new inversion mode that does simple rootfinding to find the outer extents of the to-be-inverted range. As a fallback method, we fall back to the old method of using
least_squaresto invert the function.Differences with the old method:
Fitterless general, it these bounds do hold for any sort of F, d model you'd throw at it (positive only).interpolate=True.