Conversation
tiagobonetti
approved these changes
Jul 23, 2025
tiagobonetti
left a comment
tiagobonetti
left a comment
Member
There was a problem hiding this comment.
Looks pretty good to me.
I left a few small questions/suggestions, but nothing critical.
honk
| "packages": None, | ||
| "pip_version": "24.0", | ||
| "pip_licenses_version": "4.4.0", | ||
| "pip_licenses_version": "1.4.0", |
Member
There was a problem hiding this comment.
Shouldn't we rename the option to reflect the underlying library?
Contributor
Author
There was a problem hiding this comment.
Indeed, renamed and I've noted it in the changelog.
| extra_argv=["-n", "auto", "-k=not test_mem_policy and not f2py"], | ||
| ) | ||
| ) | ||
| # `--ignore-glob` expands patterns as absolute paths in the current folder |
Member
There was a problem hiding this comment.
I don't get what this comment is referring to.
Contributor
Author
There was a problem hiding this comment.
Yeah, the comment wasn't very helpful. I've expanded it with more info. This also made me realize that the chdir() I had there originally (Path.home()) was too broad. The Python prefix path is where numpy is actually installed in the embedded environment.
# pytest's `--ignore-glob` option (see below) expands patterns as absolute paths in the
# current folder. By default, that's our project folder, but we want to ignore some numpy
# tests so we must target the Python prefix instead.
os.chdir(sys.prefix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pip-licenseslibrary that we've been using to collect licenses hasn't been maintained in a long time and is falling behind on compatibility: raimon49/pip-licenses#227 The maintained fork/successor ispip-licenses-cli. It's a drop-in replacement so this is an easy fix.This PR also does some general maintenance. See the individual commits and changelog entries for more details.