Skip to content

chore(visual-diff): factorize as a script, build a single folder and upload it#1545

Open
gcornut wants to merge 1 commit intomasterfrom
chore_visual-diffs_improve_local_script_dx
Open

chore(visual-diff): factorize as a script, build a single folder and upload it#1545
gcornut wants to merge 1 commit intomasterfrom
chore_visual-diffs_improve_local_script_dx

Conversation

@gcornut
Copy link
Member

@gcornut gcornut commented Mar 6, 2026

General summary

  • Create yarn visual-diffs to run visual diff locally
  • Consolidate diffs in a single folder (intra framework diffs and cross framework diffs)
  • Upload all diffs in an artifact (not just react and vue diffs)
  • Move unchanded screenshots into a zip archive to avoid large amount of files

StoryBook lumx-react: https://7751785cb--5fbfb1d508c0520021560f10.chromatic.com/

StoryBook lumx-vue: https://7751785cb--697a023f84e832e23544fb3c.chromatic.com/

@gcornut gcornut force-pushed the chore_visual-diffs_improve_local_script_dx branch from 64a0436 to 4443282 Compare March 6, 2026 16:44
@gcornut gcornut marked this pull request as ready for review March 6, 2026 16:44
@gcornut gcornut requested review from a team and lumautomation as code owners March 6, 2026 16:44
@gcornut gcornut force-pushed the chore_visual-diffs_improve_local_script_dx branch from 4443282 to 3138d9d Compare March 6, 2026 17:26
@gcornut gcornut force-pushed the chore_visual-diffs_improve_local_script_dx branch from 3138d9d to 7751785 Compare March 6, 2026 17:41
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Visual Regression Report

@lumx/react — 3 difference(s)

@lumx/vue — No changes

@lumx/react vs @lumx/vue — 4 difference(s) (out of 219), 302 React-only


View full report · Download artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant