Skip to content

chore(deploy-storybook): improve stroybook deploy workflows#1541

Merged
gcornut merged 1 commit intomasterfrom
chore_deploy-storybook_improve_stroybook_deploy_workflows
Mar 10, 2026
Merged

chore(deploy-storybook): improve stroybook deploy workflows#1541
gcornut merged 1 commit intomasterfrom
chore_deploy-storybook_improve_stroybook_deploy_workflows

Conversation

@gcornut
Copy link
Copy Markdown
Member

@gcornut gcornut commented Mar 6, 2026

General summary

  • Refactored cd-deploy-storybook.yaml to use pull_request trigger and nx affected to only deploy storybooks for packages impacted by PR changes (instead of deploying on every push)
  • Extracted reusable workflow-deploy-storybook.yml and added it to cd-publish.yml for release deploys on master
  • Added github_token input to update-pr-body action and use GITBOT_TOKEN in deploy workflow to fix "Resource not accessible by integration" errors on Dependabot PRs
  • Changed Chromatic autoAcceptChanges from "master" to true in both lumx-react and lumx-vue configs

StoryBook lumx-react: https://b6cd9e63f--5fbfb1d508c0520021560f10.chromatic.com/

StoryBook lumx-vue: https://b6cd9e63f--697a023f84e832e23544fb3c.chromatic.com/

@gcornut gcornut marked this pull request as ready for review March 6, 2026 11:50
@gcornut gcornut requested review from a team and lumautomation as code owners March 6, 2026 11:50
@gcornut gcornut force-pushed the chore_deploy-storybook_improve_stroybook_deploy_workflows branch 2 times, most recently from 4c58ee8 to 6f28d10 Compare March 10, 2026 10:32
@gcornut gcornut force-pushed the chore_deploy-storybook_improve_stroybook_deploy_workflows branch from 6f28d10 to e632bb0 Compare March 10, 2026 13:30
@github-actions
Copy link
Copy Markdown

Visual Regression Report

All screenshots match the baselines.

@lumx/react — No changes

@lumx/vue — No changes

@lumx/react vs @lumx/vue — No differences


View full report · Download artifacts

@gcornut gcornut merged commit 616dbc1 into master Mar 10, 2026
17 checks passed
@gcornut gcornut deleted the chore_deploy-storybook_improve_stroybook_deploy_workflows branch March 10, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants