Conversation
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
leo-assistant-chef
left a comment
There was a problem hiding this comment.
📋 Review — docs (PR #1330)
Overall this is a solid first pass — well-structured, good framework coverage, and the API reference table is clean. A few issues worth addressing before merge, ranging from a subtle bug in the React example to some missing dependency notes that will trip up developers.
Summary of findings:
- 🔴 1 bug: React example has a race condition (module-level connector var)
- 🟠 2 footguns:
enableTestnet: truedefault + missing peer dep info - 🟡 3 clarity gaps:
@lukso/coreinstall undocumented, undefined var in i18n example, Svelte version ambiguity - 🔵 1 structural: missing index/overview page for the section
Inline comments below on specific lines.
👨🏻🍳 Kitchen Review —
|
CJ42
left a comment
There was a problem hiding this comment.
LGTM, added some extra review comments
Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
…rk/docs into feat/up-modal-docs-DEV-15848
…al-docs-DEV-15848
DEV-15848