Don't output temporary directories#107
Merged
Merged
Conversation
jjudd
requested changes
Apr 3, 2026
jjudd
left a comment
jjudd
left a comment
There was a problem hiding this comment.
Thanks for doing this. I have a small request about creation of the temp directory in the worker. Other than that, it LGTM.
JaredNeil
approved these changes
Apr 3, 2026
jadenPete
force-pushed
the
jpeterson-removes-tmp-as-an-output
branch
from
942bd51 to
589c0d4
Compare
Previously, the Scala rules declared temporary directories via `ctx.actions.declare_directory` and outputted these directories. My guess is that we did this either to get Bazel not to complain about them being unused or for debugging purposes. This is unnecessary (and actually slower in the context of remote execution), so this commit updates the simple rules to use `mktemp -d` and the persistent worker-backed rules to use the sandbox directory as a temporary directory.
jjudd
approved these changes
Apr 3, 2026
jadenPete
force-pushed
the
jpeterson-removes-tmp-as-an-output
branch
from
589c0d4 to
1d8e15e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Scala rules declared temporary directories via
ctx.actions.declare_directoryand outputted these directories. My guess is that we did this either to get Bazel not to complain about them being unused or for debugging purposes.This is unnecessary (and actually slower in the context of remote execution), so this commit updates the simple rules to use
mktemp -dand the persistent worker-backed rules to use the sandbox directory as a temporary directory.