Skip to content

Ignore interrupts if there's something to read #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
coreywoodfield wants to merge 1 commit into
base: lucid
Choose a base branch
from
Draft

Ignore interrupts if there's something to read #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion persistentworkers/src/main/java/persistent/bazel/processes/ProtoWorkerRW.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,18 @@ public static void waitForInput(Supplier<Boolean> liveCheck, InputStream inputSt
String workerDeathMsg = "Worker process for died while waiting for response";
// TODO can we do better than spinning? i.e. condition variable?
while (inputAvailable(inputStream, workerDeathMsg) == 0) {
Thread.sleep(10);
try {
Thread.sleep(10);
} catch (InterruptedException e) {
if (inputAvailable(inputStream, workerDeathMsg) > 0) {
// we were interrupted because the task is complete and we're still spinning: if there's a work response
// available, read it and ignore the interrupt
Thread.currentThread().interrupt();
return;
} else {
throw e;
}
}
if (!liveCheck.get()) {
throw new IOException(workerDeathMsg + "\n");
}
Expand Down