Remove getModelStatus extra arg #44
Open
facundosw wants to merge 3 commits into
Open
Conversation
lovasoa
requested changes
Dec 20, 2024
Owner
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
I'd rather have this be a smaller pull request without a huge model
|
|
||
| function test_getModelStatus_args(Module) { | ||
| // See https://github.com/lovasoa/highs-js/issues/42 | ||
| const pb = fs.readFileSync(__dirname + '/large_test_model.lp'); |
Owner
There was a problem hiding this comment.
Could you use a smaller example here?
|
@facundosw i just tried the failing example you provided as a test and got error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the extra arguments from getModelStatus in the src\post.js file, resolving issue
Assertion failed: native function Highs_getModelStatus called with 2 args but expects 1, reported in #42, and adds a test which fails without the changes.