Fix live search IDs and avoid direct-playing addon URLs#169
Open
0oAstro wants to merge 1 commit into
Open
Conversation
lostb1t
requested changes
May 20, 2026
| //source.Path = "/stub"; | ||
| //source.IsRemote = false; | ||
| // source.Protocol = MediaProtocol.File; | ||
| source.SupportsDirectPlay = false; |
Owner
There was a problem hiding this comment.
im hesitant on this. We dont know what clients ise this for. Maybe it will prevent them for direct playing at all wand a build a transcodee url themselves. If we just stub the path it should be enough
| if (baseItem is null) | ||
| continue; | ||
|
|
||
| if (manager.FindExistingItem(baseItem) is { } existing) |
Owner
There was a problem hiding this comment.
this is slow. I dont think its necessarily needed if the insert action catches all routes properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related live-search/playback failure modes:
/Items/{id}could 404Changes
manager.FindExistingItem(baseItem)inSearchActionFilter.ConvertMetasToDtosand return the canonical item DTO when present.SupportsDirectPlay=falseand stub URL paths in DTO/playback responses so clients use Jellyfin as the proxy instead of trying to open addon-internal URLs directly.Local verification
Verified against a Jellyfin 10.11.x + Gelato 0.26.15.1 install:
matrix reloadedreturned canonical Jellyfin item id instead of synthetic id./Users/{userId}/Items/{canonicalId}returned 200./Items/{canonicalId}/PlaybackInfo?UserId=...returned media source path/stub,Protocol=File,IsRemote=false,SupportsDirectPlay=false,SupportsDirectStream=true./Videos/{canonicalId}/stream.mkv?MediaSourceId={canonicalId}&Static=truereturned HTTP 200 and started streaming via Jellyfin.Closes #168.