Skip to content

fix: pass through cargo install --path#930

Merged
loonghao merged 2 commits into
loonghao:mainfrom
piorpua:fix/cargo-install-path-bridge
May 28, 2026
Merged

fix: pass through cargo install --path#930
loonghao merged 2 commits into
loonghao:mainfrom
piorpua:fix/cargo-install-path-bridge

Conversation

@piorpua
Copy link
Copy Markdown

@piorpua piorpua commented May 28, 2026

Summary

  • Treat cargo install --path <dir> as a native cargo install, not a vx global package install
  • Add a regression case so local path installs are not routed through the global package bridge

Test Plan

  • vx cargo test -p vx-cli --test npm_global_bridge_tests
  • vx cargo fmt --all -- --check
  • vx git diff --check

@piorpua
Copy link
Copy Markdown
Author

piorpua commented May 28, 2026

Updated after review:

  • Handles both --path <dir> and --path=<dir> forms.
  • Also skips the global-package bridge for Cargo external/non-default sources: --git, --registry, and --index, including --flag=value variants.
  • Added regression cases for those forms, including --path <dir> --verbose.

Verification:

  • vx cargo test -p vx-cli --test npm_global_bridge_tests (34 passed)
  • vx cargo fmt --all -- --check
  • vx git diff --check

@loonghao loonghao merged commit 22cafd5 into loonghao:main May 28, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants