This repository was archived by the owner on Sep 25, 2020. It is now read-only.
updated Python examples to explain latest syntax#51
Open
ContrastingSounds wants to merge 1 commit into
Open
Conversation
tjirab
reviewed
Jun 17, 2020
Comment on lines
+8
to
+11
| fields = [ | ||
| 'hits_eventInfo.eventAction', | ||
| 'hits_eventInfo.eventCategory', | ||
| ] |
There was a problem hiding this comment.
Perhaps useful to clarify fields and sort_order take input as <model>.<dimension|measure>.
Contributor
|
@ContrastingSounds sorry this slipped of my radar. I think we updated the examples to just reflect the latest method of client instantiation. But I see you added an example here for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was a bit confusing having both syntaxes in the code examples (sdk = client.setup(), sdk = looker_sdk.init31(). The older examples still have value, so put them into a folder and updated README. Also, added a run_line_query example..