This repository was archived by the owner on Sep 25, 2020. It is now read-only.
Python: An example custom config reader#47
Open
josephaxisa wants to merge 4 commits into
Open
Conversation
rollyjoel
suggested changes
Mar 19, 2020
rollyjoel
left a comment
rollyjoel
left a comment
Contributor
There was a problem hiding this comment.
thanks for jumping on this! but let's hold off till I have the Python SDK trued up, at least with regards to the PApiSettings interface
Comment on lines
+25
to
+29
| def get_client_id(self) -> str: | ||
| return "client_id" | ||
|
|
||
| def get_client_secret(self) -> str: | ||
| return "client_id" |
Contributor
There was a problem hiding this comment.
ug, so this was a discrepancy that needs to be fixed. typescript/looker/rtl/apiSettings.ts exposes readConfig as opposed to get_client_id and get_client_secret. That's because we're going to have other means (like the new OAuth stuff). We should implement extracting the client id/secret inside the auth session login.
Let's hold off on merging this till I fix that up. Then this example will implement read_config() and put "client_id" and "client_secret" keys into the "bag"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.