Skip to content
This repository was archived by the owner on Sep 25, 2020. It is now read-only.

hackathon app: localize#38

Open
josephaxisa wants to merge 3 commits into
masterfrom
jax/localization-support
Open

hackathon app: localize#38
josephaxisa wants to merge 3 commits into
masterfrom
jax/localization-support

Conversation

@josephaxisa

Copy link
Copy Markdown
Contributor

No description provided.

@jkaster jkaster left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far. I don't see the english strings file though. We should also discuss with @dthorpe and Andrew whether this is the correct localization architecture to use for this

@dthorpe

dthorpe commented Feb 26, 2020

Copy link
Copy Markdown

Wondering what that browser locale discovery thing uses to select locale

@mdodgelooker

Copy link
Copy Markdown
Contributor

Hi @josephaxisa sorry for the delay...

  1. Were you planning to add the en_US json?
  2. checkboxError translation is missing
  3. Hackathon dropdown error message is not localized
    image

@josephaxisa

josephaxisa commented Feb 26, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @mdodgelooker, I have been planning to get that fixed. I wanted to see if the approach I took was architecturally sound more than anything.

@mdodgelooker mdodgelooker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephaxisa as a start it looks good architecturally to me (lens is planning to use i18next as well) – once you add the English strings and fix the un-localized string, should be GTG!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants