This repository was archived by the owner on Sep 25, 2020. It is now read-only.
hackathon app: localize#38
Open
josephaxisa wants to merge 3 commits into
Open
Conversation
dthorpe
approved these changes
Feb 26, 2020
|
Wondering what that browser locale discovery thing uses to select locale |
Contributor
|
Hi @josephaxisa sorry for the delay... |
Contributor
Author
|
Thanks @mdodgelooker, I have been planning to get that fixed. I wanted to see if the approach I took was architecturally sound more than anything. |
mdodgelooker
suggested changes
Feb 27, 2020
mdodgelooker
left a comment
Contributor
There was a problem hiding this comment.
@josephaxisa as a start it looks good architecturally to me (lens is planning to use i18next as well) – once you add the English strings and fix the un-localized string, should be GTG!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.