Skip to content

feat: Rewrite in Go plus full api coverage and OAuth support#281

Open
drstrangelooker wants to merge 36 commits into
mainfrom
go
Open

feat: Rewrite in Go plus full api coverage and OAuth support#281
drstrangelooker wants to merge 36 commits into
mainfrom
go

Conversation

@drstrangelooker

@drstrangelooker drstrangelooker commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Release-As: 0.4.0

@drstrangelooker drstrangelooker requested a review from a team as a code owner June 1, 2026 19:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a complete Go-based rewrite of the Looker Content Utility (gzr), replacing the original Ruby codebase. It introduces a robust CLI using Cobra, supporting Looker API 4.0 resource management and OAuth PKCE authentication. The review feedback highlights several critical issues, including compilation errors due to missing pointer dereferences and type mismatches in alert.go, attribute.go, dashboard.go, and space.go. Additionally, manual HTTP requests in project_files.go bypass authentication headers, the sudo logic is bypassed for direct tokens in client.go, and token_file.go requires explicit permission enforcement to prevent insecure file permissions.

Comment thread internal/cmd/project_files.go
Comment thread internal/client/client.go Outdated
Comment thread internal/cmd/alert.go
Comment thread internal/cmd/attribute.go
Comment thread internal/cmd/dashboard.go
Comment thread internal/cmd/folder.go
Comment thread internal/cmd/folder.go
Comment thread internal/cmd/folder.go
Comment thread internal/client/token_file.go
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

CI Tests

  4 files   24 suites   0s ⏱️
 70 tests  70 ✅ 0 💤 0 ❌
280 runs  280 ✅ 0 💤 0 ❌

Results for commit 31c330d.

♻️ This comment has been updated with latest results.

@drstrangelooker drstrangelooker force-pushed the go branch 5 times, most recently from 5502e43 to b125580 Compare June 1, 2026 20:29
@drstrangelooker

Copy link
Copy Markdown
Collaborator Author

@joshtemple I addressed everything Gemini came up with. You can pull this branch and build with go build -o looker-cli ./cmd/looker-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant