Fix Unicode character handling in API responses#44
Open
solavrc wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
solavrc
commented
Mar 25, 2025
Comment on lines
+16
to
+19
| // Convert base64 to binary data using the approach from MDN | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Window/btoa#unicode_strings | ||
| const binString = atob(base64String); | ||
| const bytes = Uint8Array.from(binString, (m) => m.charCodeAt(0)); |
Author
There was a problem hiding this comment.
The webpack configuration explicitly disables Buffer polyfill with:
dashboard-summarization/webpack.config.js
Lines 76 to 78 in af034be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the backend returns responses containing Unicode characters (like Japanese), the Looker proxy encounters character encoding issues and returns 500 errors to the frontend.
Solution
This PR implements a base64 encoding/decoding approach to safely transmit Unicode characters:
Implementation Details
Buffer.from(JSON.stringify()).toString('base64')base64Helper.tsutility for frontend to decode responses with Unicode supportThis approach ensures consistent handling of all character sets, including Japanese, without relying on Looker proxy's character encoding capabilities.