[WIP] initial implementation of skipping prefix hash#26
Open
wiibaa wants to merge 1 commit into
Open
Conversation
ad49389 to
e9fe1af
Compare
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #25, when storing metrics into a hash, one could prefer to strip the name of the "container" from the metrics name outputting
foo.barto graphite instead ofmymetrics.foo.barwhen the event contains a field
mymetricsof type HashThis PR propose to add a boolean config to strip this prefix and help is wanted in finding the best name for it as it is only applicable to hash-fields.
I'm still working on the doc and the spec, but would like feedback for the field name
@jsvd @purbon @jordansissel want to propose something better than skip_prefix_for_metrics_hash ?