Skip to content

Add symlink traversal#89

Open
jrcichra wants to merge 1 commit into
logstash-plugins:mainfrom
jrcichra:symlink-traversal
Open

Add symlink traversal#89
jrcichra wants to merge 1 commit into
logstash-plugins:mainfrom
jrcichra:symlink-traversal

Conversation

@jrcichra

@jrcichra jrcichra commented Sep 2, 2020

Copy link
Copy Markdown

This PR allows pre-existing, strategically placed symlinks, to no longer fail on mkdir_p calls.

I've replaced mkdir_p with a loop per directory that only creates the directory if the directory doesn't exist and is not a symlink.

This solves: #87

CLA is signed (Corporation + Individual under corporation [NetApp] applies here).

@jrcichra

Copy link
Copy Markdown
Author

@roaksoax Could someone please review this? Thanks.

@jrcichra

Copy link
Copy Markdown
Author

@jsvd @roaksoax Could this please be reviewed? We'd really like to have this feature upstream. Thanks.

@jonathonpuff

Copy link
Copy Markdown

@jsvd @roaksoax looking for your help here.

@jonathonpuff

Copy link
Copy Markdown

@jsvd @roaksoax checking back in to see if we get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants