Fix potential out of bounds index in test#90
Open
juusom wants to merge 1 commit into
Open
Conversation
kares
reviewed
May 12, 2021
Comment on lines
+27
to
+30
| [0, 100, 1000].each do |idx| | ||
| idx = [idx, event_count - 1].min | ||
| expect(events[idx].get('sequence')).to eq idx | ||
| end |
Contributor
There was a problem hiding this comment.
Thanks Juuso, indeed it's me to blame.
While your code fixes the issue it requires extra 🤔 could we just hard-code 999:
Suggested change
| [0, 100, 1000].each do |idx| | |
| idx = [idx, event_count - 1].min | |
| expect(events[idx].get('sequence')).to eq idx | |
| end | |
| [0, 100, 999].each do |idx| | |
| expect(events[idx].get('sequence')).to eq idx | |
| end |
Author
There was a problem hiding this comment.
Sure, I don't mind. I just figured it would make sense to have a bit more generic approach because this way the function requires to input to be >=1000.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on merging master to #81 I noticed that the
processfunction in the integration tests assumes that indices100and1000exist. Currently, theevent_countthat gets passed into the method is1000 + rand(50).rand(50)may return0, yielding a count of1000and a maximum index of999.This should make the function a bit safer.