Skip to content

Fix PDController#144

Open
timtmit wants to merge 2 commits intoloco-3d:mainfrom
timtmit:fix/timtmit/pinDiff
Open

Fix PDController#144
timtmit wants to merge 2 commits intoloco-3d:mainfrom
timtmit:fix/timtmit/pinDiff

Conversation

@timtmit
Copy link
Copy Markdown

@timtmit timtmit commented Mar 19, 2026

use pinocchio::difference in pd controller to handle SO2 joint

@timtmit timtmit marked this pull request as draft March 25, 2026 07:57
@timtmit timtmit marked this pull request as ready for review March 31, 2026 12:52
@nim65s
Copy link
Copy Markdown
Contributor

nim65s commented Apr 9, 2026

Hi @timtmit,

There are some failing tests in the ROS CI, and I also have those 2 failures locally:

The following tests FAILED:
	 1 - test_pd_controller (Failed)
	 2 - test_linear_feedback_controller (Failed)

Did you check that ?

Nix CI is also outdated, so you may need to rebase to fix that one (I can do that for you if you prefer)

@timtmit
Copy link
Copy Markdown
Author

timtmit commented Apr 13, 2026

Hi @timtmit,

There are some failing tests in the ROS CI, and I also have those 2 failures locally:

The following tests FAILED:
	 1 - test_pd_controller (Failed)
	 2 - test_linear_feedback_controller (Failed)

Did you check that ?

Nix CI is also outdated, so you may need to rebase to fix that one (I can do that for you if you prefer)

Hi @nim65s, sorry about that, I completely forgot about this PR and didn’t pay attention to the CI when I opened it.
I’ll take a look at the failing tests and fix everything this week. Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants