Skip to content

Update pretty much everything#28

Merged
alexrashed merged 6 commits into
mainfrom
update
May 7, 2026
Merged

Update pretty much everything#28
alexrashed merged 6 commits into
mainfrom
update

Conversation

@alexrashed
Copy link
Copy Markdown
Member

@alexrashed alexrashed commented May 7, 2026

Motivation

We use this GitHub action in a lot of workflows. Wherever this is used right now, we do get a warning that this action still uses Node 20 which will see EOL on runners in June.
This PR updates pretty much everything: the runtime, updates all dependencies, all GitHub actions, and the test framework.

Changes

  • 9b0b25f performs a basic update, use the latest possible version everywhere.
  • 47fadfd then moves a bit further and updates the dependencies above their given boundaries and switches from ncc to esbuild (which appears to be the new best practice to bundle GitHub actions)
  • 64be94c The switch to ESM caused some overhead with jest because it has limited support for ESM, which is why this commit switches the tests to vitest.
  • eddf852 finally updates to node 24
  • e8b5e0a fixes the checkout action in the linter workflow according to their README
  • c17e157 fixes all kinds of linting issues that showed up in the linting action

@alexrashed alexrashed requested a review from silv-io May 7, 2026 07:37
@alexrashed alexrashed added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels May 7, 2026
@alexrashed alexrashed marked this pull request as draft May 7, 2026 07:41
jest runs in CommonJS mode, so it can't resolve the ESM package,
in order to clean things up and get rid of the __mocks__, we
switch to vitest which seems to be a modern alternative.
@alexrashed alexrashed marked this pull request as ready for review May 7, 2026 08:43
Copy link
Copy Markdown
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread __tests__/main.test.ts
@@ -1,21 +1,22 @@
import { vi, describe, it, expect, beforeEach } from 'vitest'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@alexrashed alexrashed merged commit 44f437c into main May 7, 2026
22 checks passed
@alexrashed alexrashed deleted the update branch May 7, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants