feat(ci): add GitHub Actions workflow and act support#14
Open
nik-localstack wants to merge 2 commits into
Open
feat(ci): add GitHub Actions workflow and act support#14nik-localstack wants to merge 2 commits into
nik-localstack wants to merge 2 commits into
Conversation
nik-localstack
force-pushed
the
unc-472-local-tests
branch
from
87aba3e to
1c4344d
Compare
nik-localstack
force-pushed
the
unc-472-ci
branch
from
ebb0387 to
0643c4b
Compare
nik-localstack
force-pushed
the
unc-472-local-tests
branch
from
1c4344d to
17640a3
Compare
nik-localstack
force-pushed
the
unc-472-ci
branch
from
0643c4b to
037d4d2
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nik-localstack
force-pushed
the
unc-472-ci
branch
from
037d4d2 to
572461b
Compare
cloutierMat
approved these changes
May 14, 2026
Member
cloutierMat
left a comment
cloutierMat
left a comment
There was a problem hiding this comment.
LGTM. I left a couple questions but nothing blocking! Glad to have some CI here. Great first step before we can enable CI releases!
|
|
||
| services: | ||
| postgres: | ||
| image: postgres:16 |
Member
There was a problem hiding this comment.
question: Any particular reason for using version 16?
Comment on lines
+22
to
+26
| options: >- | ||
| --health-cmd "pg_isready -U postgres" | ||
| --health-interval 10s | ||
| --health-timeout 5s | ||
| --health-retries 5 |
Member
There was a problem hiding this comment.
Question: Are the health checks of the postgres image not enough?
Member
There was a problem hiding this comment.
should we also add a linting step?
Comment on lines
+51
to
+53
| - name: Run tests | ||
| run: | | ||
| python -m pytest -vv |
Member
There was a problem hiding this comment.
nit: As I mentioned on #13 if we clean up the make command, we could probably reuse make test?
| ACT_PULL ?= false | ||
| ACT_CONTAINER_ARCH ?= linux/arm64 | ||
|
|
||
| test-act: ## Run the CI test workflow locally with act |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #13.
This PR adds a GitHub Actions CI workflow that runs the full test suite on Python 3.13, along with
actsupport for running the same workflow locally.Changes
.github/workflows/tests.yml: runs the full test suite on Python 3.13 via GitHub Actions.actrc: default flags for running the workflow locally withactMakefiletarget:test-act(runs the CI workflow locally viaact)README.mdtesting section withactinstructions