Skip to content

Hash auth token in telemetry events#245

Closed
gtsiolis wants to merge 1 commit into
mainfrom
des-228-hash-the-auth-token-in-telemetry
Closed

Hash auth token in telemetry events#245
gtsiolis wants to merge 1 commit into
mainfrom
des-228-hash-the-auth-token-in-telemetry

Conversation

@gtsiolis
Copy link
Copy Markdown
Member

The auth token was previously sent in the auth_token_id field of every telemetry event. We don't need the raw value to correlate events per user, but a stable fingerprint is enough. Switching to a hash keeps the credential out of telemetry payloads while preserving the analytics signal.

@gtsiolis gtsiolis force-pushed the des-228-hash-the-auth-token-in-telemetry branch from 426a95e to 0f8c9d8 Compare May 14, 2026 15:13
Copy link
Copy Markdown
Collaborator

@anisaoshafi anisaoshafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @gtsiolis 🔐
I wanted to mitigate this similarly, but my understanding is that it breaks the data contract
I'll defer to @thrau for his data expertise 🙏🏼

@anisaoshafi anisaoshafi requested a review from thrau May 14, 2026 15:15
Copy link
Copy Markdown
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principle sending a stable hash instead of the actual key would be a great idea! unfortunately, all our data pipelines that join usage data with user and subscription data currently rely on the actual auth token.

so tthis change would require a significant refactor of our data pipelines. i don't have a complete picture of what this would mean right now. is there anything i might be missing?

@gtsiolis
Copy link
Copy Markdown
Member Author

Thanks, @thrau! Closing for now, we may get to it later if needed.

@gtsiolis gtsiolis closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants