Hash auth token in telemetry events#245
Closed
gtsiolis wants to merge 1 commit into
Closed
Conversation
426a95e to
0f8c9d8
Compare
anisaoshafi
reviewed
May 14, 2026
thrau
reviewed
May 14, 2026
Member
thrau
left a comment
There was a problem hiding this comment.
in principle sending a stable hash instead of the actual key would be a great idea! unfortunately, all our data pipelines that join usage data with user and subscription data currently rely on the actual auth token.
so tthis change would require a significant refactor of our data pipelines. i don't have a complete picture of what this would mean right now. is there anything i might be missing?
Member
Author
|
Thanks, @thrau! Closing for now, we may get to it later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth token was previously sent in the
auth_token_idfield of every telemetry event. We don't need the raw value to correlate events per user, but a stable fingerprint is enough. Switching to a hash keeps the credential out of telemetry payloads while preserving the analytics signal.