Surface persistence in start and status commands#244
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
|
@gtsiolis can you open separate PRs for the other changes? There seem to be some changes about the displayed host and some snowflake header changes? Not sure. It's a little hard to read at the moment. |
|
Makes sense. I had a feeling I would have to split this one, will split later. ⏳ |
gtsiolis
force-pushed
the
des-230-surface-persistence-state-in-status-and-start-commands
branch
2 times, most recently
from
b046e9b to
dfac5a0
Compare
|
Updated PR to include only the Persistence metadata in the header without additional cleanup, plus show the metadata only for AWS emulation. Curious what you think! |
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Thanks George, this is useful 🙌🏼
PR description mentions this should work when LOCALSTACK_PERSISTENCE=1 is set in shell, but doesn't seem to.
Same when LOCALSTACK_PERSISTENCE is set in the config profile.
gtsiolis
force-pushed
the
des-230-surface-persistence-state-in-status-and-start-commands
branch
from
b548c5c to
082c7e1
Compare
|
Great catch, @anisaoshafi! Added 082c7e1 to make this work also with the inline environment variable. Thoughts? |
3 participants
Adds a
Persistence: Enabledbullet to the start info block and the status output when the running instance hasLOCALSTACK_PERSISTENCE=1set — either via--persistor by inheriting the env var from the host shell. restart benefits transitively since it dispatches through start.