fix module imports#135
Merged
Merged
Conversation
simonrw
approved these changes
Jul 9, 2025
Collaborator
simonrw
left a comment
There was a problem hiding this comment.
It's a shame we have to manually declare exports, however I have struggled for ages trying to get this code working across different JS implementations, and I don't understand it all so it was amazing it worked in the first place!
Member
Author
|
Thanks for the review. Before merging, I will start a changelog in the README, similar to what we have for the airspeed library. That should enable us to properly mange versions of this library in the near future |
db133e2 to
f2d0150
Compare
f2d0150 to
fd9804b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of the appsync execution rework, we lost the ability to pass in
--experimental-specifier-resolution=nodewhen executing JS code. This is probably a good thing since it could have blocked us from future versions of node.The sad consequences is that we lost the capabilities to import without specifying the file name for
rdsanddynamodb.Explicitly declaring the exports will bring about parity with aws as to how to import appsync-utils module within a user function.