Add support for delaying responses to mimic real APIs.#29
Open
austburn wants to merge 1 commit intolocalmed:masterfrom
Open
Add support for delaying responses to mimic real APIs.#29austburn wants to merge 1 commit intolocalmed:masterfrom
austburn wants to merge 1 commit intolocalmed:masterfrom
Conversation
Author
|
Wondering what your thoughts might be on this. I'm not too familiar with coffeescript/sinon, so I may need help testing if approved. |
Author
There was a problem hiding this comment.
Not familiar with coffeescript, but this does produce some weirdness when compiled:
return setTimeout((function() {
return res.send(response.status, response.body);
}), delay);
|
👍 |
|
Wondering when this could be merged to master? |
|
This would be a very useful feature. I'd rather be able to get it from NPM than having point at austburn:api-response-delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.