fix: add process group management and interactive command detection for shell MCP#5
Closed
localai-bot wants to merge 12 commits into
Closed
fix: add process group management and interactive command detection for shell MCP#5localai-bot wants to merge 12 commits into
localai-bot wants to merge 12 commits into
Conversation
Co-authored-by: localai-bot <localai-bot@users.noreply.github.com>
Changed base image from Debian to Ubuntu and updated GitHub CLI installation method.
Removed 'software-properties-common' from the Dockerfile.
Removed specific Docker image entries and added placeholders for components.
A no-op tool that forces the model to think about a message. Takes a message string input and echoes it back, useful for debugging or forcing explicit reasoning steps in the model.
* feat: add think MCP server A no-op tool that forces the model to think about a message. Takes a message string input and echoes it back, useful for debugging or forcing explicit reasoning steps in the model. * feat(localrecall): gate all log messages under DEBUG flag - Add debugMode boolean that reads from DEBUG environment variable - Create debugLog() helper function that only prints when DEBUG=1 - Replace all log.Printf/log.Println calls with debugLog() - By default, no logs are emitted to preserve JSON-RPC stdio protocol Fixes: The LocalRecall MCP was corrupting JSON-RPC communication by emitting logs to stdout, causing the container to fail. Logs are now only shown when DEBUG=1 is set.
* feat: add codemogger MCP server - Add Dockerfile for codemogger (Node.js based MCP server) - Add codemogger to GitHub Actions CI pipeline * fix: remove redundant npm install -g npx (npx is included in node:20-slim) * docs: add codemogger to README
- Add getTimeout() function to read SHELL_TIMEOUT env var (default: 30s) - Update ExecuteCommand to use getTimeout() instead of hardcoded value - Update tool description to document the new env variable
…or shell MCP - Add syscall.Setpgid to create new process group for proper child process cleanup - Add detectInteractiveCommands function to warn about potentially interactive commands - Add process group kill on timeout to ensure all child processes are terminated - Update description to reflect new capabilities Fixes issue mudler#20 - Interactive commands causing MCP shell to stall indefinitely
Owner
Author
|
🤖 Auto-Verification: The branch has been verified and is already rebased on top of the latest upstream/master. No rebase action was needed. The branch is ready for review. |
Owner
Author
|
✅ Branch has been rebased on upstream/master as requested. The PR is now up to date and ready for review. |
Owner
Author
|
Closing because this PR was opened against the wrong repository. A new PR will be created against the upstream repository (mudler/MCPs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue mudler#20 - Interactive commands causing MCP shell to stall indefinitely.
Changes
Testing
The fix ensures that:
Fixes: mudler#20