Skip to content

Add novelarrow#2239

Merged
K1ngfish3r merged 9 commits into
lnreader:masterfrom
7ui77:add-novelarrow
Jun 13, 2026
Merged

Add novelarrow#2239
K1ngfish3r merged 9 commits into
lnreader:masterfrom
7ui77:add-novelarrow

Conversation

@7ui77

@7ui77 7ui77 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

why does this close 2237?

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

please do an interactive git rebase and drop unneeded commits

@7ui77

7ui77 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

why does this close 2237?

"Sorry, my bad. I have another branch to fix the bugs for the NovelBin plugin."

@7ui77 7ui77 force-pushed the add-novelarrow branch 2 times, most recently from 99f9e29 to ea560bc Compare June 5, 2026 23:13
@7ui77

7ui77 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

please do an interactive git rebase and drop unneeded commits

Done!

@K1ngfish3r K1ngfish3r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin works well, fix the things and add the icon

Comment thread plugins/english/novelarrow.ts Outdated
Comment thread plugins/english/novelarrow.ts Outdated
class NovelArrow implements Plugin {
id = 'novelarrow';
name = 'Novel Arrow';
icon = 'https://novelarrow.com/favicon-32.png';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an image to public/static/src/en

Comment thread plugins/english/novelarrow.ts Outdated
Comment thread plugins/english/novelarrow.ts Outdated
Comment thread plugins/english/novelarrow.ts Outdated
Comment thread plugins/english/novelarrow.ts Outdated
Comment on lines +13 to +21
// Required headers to bypass Cloudflare and simulate a mobile browser
headers = {
'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8',
'User-Agent': 'Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Mobile Safari/537.36',
'Referer': 'https://novelarrow.com/',
'x-client-platform': 'web-mobile',
'x-device-type': 'mobile',
'x-version-app': 'web-mobile',
};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically you would force a desktop UA, not the other around (considering our main audience is mobile only anyways

Comment thread plugins/english/novelarrow.ts Outdated
7ui77 and others added 8 commits June 13, 2026 20:50
Co-authored-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Co-authored-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Co-authored-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Co-authored-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Co-authored-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
@K1ngfish3r

Copy link
Copy Markdown
Collaborator

werent the headers required to bypass cf?

 // Required headers to bypass Cloudflare and simulate a mobile browser

why delete?
is it even required in the first place?

@7ui77

7ui77 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

werent the headers required to bypass cf?

 // Required headers to bypass Cloudflare and simulate a mobile browser

why delete? is it even required in the first place?

I only need the header because I'm using CLI commands to test the code. When pushing to the application, this header isn't needed.

@7ui77 7ui77 requested a review from K1ngfish3r June 13, 2026 14:29
@K1ngfish3r K1ngfish3r merged commit 2680752 into lnreader:master Jun 13, 2026
1 check passed
@7ui77 7ui77 deleted the add-novelarrow branch June 13, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants