Fix Windows IOCP TcpClient: Init() returns true even when bind fails

[Copilot]

TcpTest.InitBindFailureInvalidatesClientSocket was failing on Windows IOCP because Init() always returned true even when the local-address bind() inside ReInit() failed (WSAEADDRINUSE / error 10048).

Root cause

ReInit() logged the bind error and returned early, but neither called closesocket() nor set socket_ = INVALID_SOCKET. Init() then unconditionally set isRunning_ = true and returned true with a live (unbound) socket — violating the expected post-condition.

The same missing cleanup existed on the inet_pton remote-address failure path.

Changes — src/platforms/windows/tcp_client_impl.cpp

• ReInit() — every early-return error path now calls closesocket(socket_) and sets socket_ = INVALID_SOCKET before returning:

  • user-specified bind() failure
  • auto-bind for ConnectEx failure
  • inet_pton remote-address failure
    (IOCP association failure already did this correctly — now consistent throughout)

• Init() — checks socket_ == INVALID_SOCKET after ReInit() and returns false with taskQueue_->Stop() cleanup:

ReInit();
if (socket_ == INVALID_SOCKET) {
    LMNET_LOGE("Failed to initialize socket");
    taskQueue_->Stop();
    return false;
}

[Copilot]

Pull request overview

Fixes a Windows IOCP TcpClientImpl initialization bug where Init() could return success even when ReInit() failed (e.g., local bind() failure), leaving the client in an invalid-but-“running” state.

Changes:

• Ensure ReInit() closes the socket and marks it INVALID_SOCKET on early-return error paths (bind failures, remote inet_pton failure).
• Make Init() validate socket_ after ReInit() and return false (with taskQueue_->Stop() cleanup) when initialization fails.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.