Draft
Conversation
Contributor
|
@gracenansamba ok so in the experiment.py for kripke there is the variant code I show below, this is setting you to the develop version when you run experiment init, so you need to pass in You should be able to do this as is, or you can update this code to look like Caliper's where you can list explicit values (you would just add comm_cali as a value): |
…Kripke_Comm_dynamic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "https://github.com/gracenansamba/Kripke.git" path to /repo/kripke/package.py and adjusted other changes comparing to my old branch kripke_comm_cali
The current error is kripke@develop required in spack concretization.
May need to make a variant but was not successful.
added these lines for the new caliper metrics.
https://github.com/LLNL/benchpark/blob/Kripke_Comm_dynamic/modifiers/caliper/modifier.py#L45C9-L45C10:
https://github.com/LLNL/benchpark/blob/Kripke_Comm_dynamic/modifiers/caliper-mpi/modifier.py#L27