Open
Conversation
added 5 commits
October 11, 2025 23:47
Fix typos in softmax_kernel comments
Update return type for layernorm bw binding
kortemaki
pushed a commit
to kortemaki/llmsys_f25_hw4-1
that referenced
this pull request
Oct 15, 2025
Update tensor.py -> fix severe memory leaking issue!
Andrea-Vigano
requested changes
Dec 16, 2025
Andrea-Vigano
left a comment
Andrea-Vigano
left a comment
There was a problem hiding this comment.
Could you revert layernorm_kernel.cu? I would like to only have the other two files merged.
Thank you for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes