fix: remove invalid inference_api parameter #4655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are-ces
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist and
slekkala1
as code owners
meta-cla
bot
added
the
CLA Signed
are-ces
changed the title
are-ces
changed the title
Collaborator
|
@are-ces please fix pre-commit |
are-ces
force-pushed
the
fix-conflicts-mergify
branch
2 times, most recently
from
b1b6852 to
5ab0582
Compare
Collaborator
|
unclear why the tests are not running |
.github/workflows/pre-commit.yml
Outdated
| UV_EXTRA_INDEX_URL: ${{ steps.client-config.outputs.uv-extra-index-url }} | ||
| UV_INDEX_STRATEGY: ${{ steps.client-config.outputs.uv-extra-index-url && 'unsafe-best-match' || '' }} | ||
| run: | | ||
| # Unset UV_INDEX_STRATEGY if empty to avoid uv errors |
Collaborator
There was a problem hiding this comment.
are these changes necessary?
franciscojavierarceo
requested changes
Jan 21, 2026
Collaborator
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
There was a problem hiding this comment.
think you should only change tests/unit/core/test_vector_store_config_registration.py please
Contributor
Author
|
I initially added the UV_INDEX_STRATEGY changes to fix a CI error (see this failed run), but have now reverted them per @franciscojavierarceo 's feedback. |
mattf
requested changes
Jan 21, 2026
Collaborator
mattf
left a comment
mattf
left a comment
There was a problem hiding this comment.
remove the changes to uv.lock
are-ces
force-pushed
the
fix-conflicts-mergify
branch
from
3ca06c1 to
82ae221
Compare
Contributor
Author
|
Done |
Collaborator
|
the lock in the release branch is outdated so we either need to update here or with another PR. |
Contributor
Author
|
Should I add the updated lock file again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failing test by removing the invalid inference_api parameter from OpenAIVectorStoreMixin initialization.
This resolves the TypeError that was occurring in the test.