feat!: improve consistency of post-training API endpoints #4606
+312
−312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates post-training job endpoints to include
{job_uuid}in the URL path instead of using it as a query parameter, while improving consistency with other Llama Stack APIs, and general adherence to RESTful conventions.Changes
POST /post-training/job/cancel→POST /post-training/jobs/{job_uuid}/cancelGET /post-training/job/status→GET /post-training/jobs/{job_uuid}/statusGET /post-training/job/artifacts→GET /post-training/jobs/{job_uuid}/artifactsMotivation
/batches/{batch_id}/cancel/eval/benchmarks/{benchmark_id}/jobs/{job_id}/files/{file_id}/conversations/{conversation_id}POST /fine_tuning/jobs/{fine_tuning_job_id}/cancelfor their fine-tuning API/jobs/instead of/job/)cancelpattern)post_trainingAPI to FastAPI router #4496, where URL paths were not updated in the FastAPI routes.Breaking Change
This is a breaking change for the v1alpha API. Users will need to:
Testing