feat: enable multi-arch arm64 builds #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doug Edgar <dedgar@redhat.com>
leseb
requested changes
Jan 20, 2026
actions/publish-dockers/main.sh
Outdated
| docker images | cat | ||
|
|
||
| echo "Pushing docker image" | ||
| echo "Building and pushing multi-arch OpenShift-compatible image" |
Collaborator
There was a problem hiding this comment.
Suggested change
| echo "Building and pushing multi-arch OpenShift-compatible image" | |
| echo "Building and pushing multi-arch image" |
actions/publish-dockers/main.sh
Outdated
| docker build "$LLAMA_STACK_DIR" \ | ||
| BASE_TAG="llamastack/distribution-$distro:$TAG_SUFFIX-base" | ||
| docker buildx build "$LLAMA_STACK_DIR" \ | ||
| --platform linux/amd64,linux/arm64 \ |
Collaborator
There was a problem hiding this comment.
should linux/amd64,linux/arm64 be a top var?
Author
There was a problem hiding this comment.
Sure, I've now replaced the 4 occurrences of that string with a new variable.
Signed-off-by: Doug Edgar <dedgar@redhat.com>
Signed-off-by: Doug Edgar <dedgar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding multi-architecture ARM64 build support to the release process.
Closes RHAIENG-2781.
Addresses
llamastack/llama-stack#4290 (comment)
as a follow-up to
llamastack/llama-stack#4290.