fix: normalize htpasswd user id to lowercase#307
Open
allamiro wants to merge 1 commit into
Open
Conversation
The LDAP backend lowercases UserInfo.id while htpasswd used it as-is. The id keys the in-memory db cache, so case variations of the same user created separate cache entries. htpasswd now lowercases like LDAP; OIDC subjects are case-sensitive opaque strings and stay as-is (documented on the trait).
allamiro
force-pushed
the
fix/user-id-normalization
branch
from
3467525 to
1bcc84c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #278.
Problem
UserInfo.idkeys the in-memoryDbCache, but backends normalized it inconsistently: LDAP lowercases, htpasswd didn't. Case variations of the same user produced duplicate cache entries (and inconsistent log identities).Changes
subvalues are case-sensitive opaque strings per spec, lowercasing could merge distinct users; this is now documented on theAuthBackendtraitTesting
cargo test: 9/9 pass.Summary by cubic
Lowercases htpasswd user IDs to match LDAP and prevent duplicate DB cache entries and inconsistent log identities. Documents that OIDC
substays case-sensitive and unchanged.UserInfo.id; displaynamekeeps original casing.Written for commit 3467525. Summary will update on new commits.