fix: evict expired entries from DbCache#302
Open
allamiro wants to merge 1 commit into
Open
Conversation
Expired encrypted databases of inactive users were never removed, so the in-memory cache grew without bound. store() now drops all expired entries before inserting (resolves the 'expire old entries' TODO).
8dc021a to
5988fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283.
Problem
DbCachechecked expiry on retrieval but never removed expired entries (long-standing TODO). With many users, encrypted databases of users who simply walked away accumulated in memory forever.Change
store()now evicts all expired entries (oneretainunder the already-held write lock) before inserting. Eviction is opportunistic — any login or expiry refresh cleans the map — which avoids a background task while bounding growth to active users.Testing
cargo test: 10/10 pass, including a new test that verifies an expired entry is dropped on the next store.Summary by cubic
Evicts expired entries from
DbCacheon store to stop unbounded growth from inactive users. Keeps memory bounded without a background task.retain).Written for commit 8dc021a. Summary will update on new commits.