fix(ldap): case-insensitive attribute lookup, request login attribute in search#296
Open
allamiro wants to merge 1 commit into
Open
fix(ldap): case-insensitive attribute lookup, request login attribute in search#296allamiro wants to merge 1 commit into
allamiro wants to merge 1 commit into
Conversation
… in search LDAP attribute names are case-insensitive (RFC 4512), but servers return them in their own canonical casing: openldap returns 'cn' for a requested 'CN', so the case-sensitive HashMap lookup failed with 'CN attribute not found' after successful credential verification. The search also only requested the CN attribute, so the login attribute (e.g. uid) was never returned and its lookup failed next. Verified end-to-end against openldap 2.6: valid credentials log in, wrong/empty passwords are rejected.
8743667 to
a9c9daa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292.
Problem
Two related bugs broke LDAP login against OpenLDAP even with correct credentials:
cnfor a requestedCN, so login failed with 'CN attribute not found'.CNattribute, so the login attribute (e.g.uid) was never in the result and its lookup failed next ('login attribute uid not found').Changes
get_attr_ci()helper for case-insensitive attribute lookup, used for CN, login attribute, database/keyfile attributesTesting
cargo test: 10/10 passinvalidCredentialsfrom user bind), empty password → rejectedSummary by cubic
Fix LDAP login failures by using case-insensitive attribute lookup and requesting the login attribute in the search. Restores compatibility with OpenLDAP and other servers that return canonical-cased attributes.
Written for commit 8743667. Summary will update on new commits.