fix: error responses incorrectly reported success: true#294
Open
allamiro wants to merge 1 commit into
Open
Conversation
Four error paths returned "success": true, which clients could misread as a successful operation: failed to store key, failed to store db, failed to retrieve session, failed to close db.
4445988 to
0394a56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280.
Problem
Four error responses carried
"success": true, so API clients could interpret hard failures as success:db_login'failed to store key'db_login'failed to store db'get_user_info'failed to retrieve session'_close_db'failed to close db'Change
All four now return
"success": false. No other behavior change.Testing
Full
cargo testsuite passes (9/9) in a rust:1.83 container.Summary by cubic
Fixed four error responses that incorrectly returned "success": true, so clients now correctly detect failures. All affected paths now return "success": false with no other behavior changes.
Written for commit 4445988. Summary will update on new commits.