fix: correct broken log statement in embed_in_index#293
Open
allamiro wants to merge 1 commit into
Open
Conversation
The error path logged "user login from '{}': " with the error
interpolated where the username should be, dropping the actual message.
Log the read failure itself at error level instead.
allamiro
force-pushed
the
fix/embed-index-log
branch
from
5757f7b to
0d953be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284.
Problem
route/auth.rs logged
info!("user login from '{}': ", err)— the error was interpolated where the username belongs and the actual error message was dropped, making index-file read failures undebuggable.Change
Log the failure as
error!("failed to read index file: {}", err)— correct severity and the real cause.Testing
Full
cargo testsuite passes (9/9) in a rust:1.83 container.Summary by cubic
Fixes incorrect logging in embed_in_index that misattributed errors to a user login message. Now logs index file read failures at error level with the actual error message for easier debugging.
Written for commit 5757f7b. Summary will update on new commits.