fix(pipeline, client): fix workspace path mapping, add --config flag option#560
Open
fix(pipeline, client): fix workspace path mapping, add --config flag option#560
--config flag option#560Conversation
- Standardize on --workspace (with --cwd alias) so ComfyStream can launch from any directory while mapping to the correct ComfyUI cwd. - Pass the workspace/CWD and logging settings cleanly through server args → pipeline → ComfyStreamClient so ComfyUI’s configuration is honored. - Add config passthrough support: when a ComfyUI config file is provided, forward it directly and skip overriding flags to match ComfyUI’s precedence rules. - Ensure ComfyUI packages load correctly via the client initialization (__init__.py/ComfyStreamClient), removing legacy env handling and relying on proper cwd/config inputs. - Update Docker, supervisord, launch configs, and docs to use the unified workspace flag and defaults.
eliteprox
changed the title
--config flag option
This reverts commit 6853675.
eliteprox
changed the title
--config flag option--config flag option
Collaborator
Author
|
This change follows up on the fix made in #549 to correct the parsing of the |
eliteprox
changed the title
--config flag option--config flag option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with ComfyStream unable to run from a directory other than ComfyUI. It also ensures that the installed ComfyUI package is used instead of the ComfyUI workspace, fixing compatibility that was broken in a previous change
This change also adds a
--configflag option for passing command line args to configure theComfyStreamClient(ComfyUI) instance with any flag provided here https://github.com/hiddenswitch/ComfyUI?tab=readme-ov-file#configuration-fileDetails of changes
--workspaceflag so ComfyStream can launch from any directory while mapping to the correct ComfyUI cwd.