feat: implement graceful draining and outbound call control for SIP#600
Closed
biswajitpain wants to merge 1 commit intolivekit:mainfrom
Closed
feat: implement graceful draining and outbound call control for SIP#600biswajitpain wants to merge 1 commit intolivekit:mainfrom
biswajitpain wants to merge 1 commit intolivekit:mainfrom
Conversation
Introduce a graceful shutdown mechanism for the SIP service. - Add `StartDrain` methods to `sip.Client`, `sip.Server`, and `sip.Service`. These methods stop accepting new inbound SIP INVITEs and new outbound `CreateSIPParticipant` requests, respectively, while allowing existing calls to complete. - Integrate the `StartDrain` call into the service shutdown sequence in `service.Run()` to immediately prevent new call establishments. - Add a `DisableOutboundCalls` configuration option to prevent new outbound SIP calls. When enabled, `CreateSIPParticipant` requests will be rejected, and affinity will be zeroed out. - Enhance the health check endpoint: - Expose `/healthz` in addition to `/`. - Implement a 30-second grace period after service stop before exiting, allowing load balancers to detect unhealthy status. - Update `.gitignore` to include `.claude`. Changes: - .gitignore (2 lines, 7 characters) - cmd/livekit-sip/main.go (2 lines, 219 characters) - pkg/config/config.go (4 lines, 274 characters) - pkg/service/service.go (26 lines, 1142 characters) - pkg/sip/client.go (6 lines, 213 characters) - pkg/sip/inbound.go (7 lines, 429 characters) - pkg/sip/server.go (6 lines, 220 characters) - pkg/sip/service.go (14 lines, 522 characters) - test/cloud/service.go (2 lines, 263 characters)
|
Biswajit Pain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a graceful shutdown mechanism for the SIP service.
StartDrainmethods tosip.Client,sip.Server, andsip.Service. These methods stop accepting new inbound SIP INVITEs and new outboundCreateSIPParticipantrequests, respectively, while allowing existing calls to complete.StartDraincall into the service shutdown sequence inservice.Run()to immediately prevent new call establishments.DisableOutboundCallsconfiguration option to prevent new outbound SIP calls. When enabled,CreateSIPParticipantrequests will be rejected, and affinity will be zeroed out./healthzin addition to/..gitignoreto include.claude.Changes: